Fix Boolean Nulls/Refactor Time Adapters/Adapter Tests #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0c070da.
|
hmm, it seems we will need a way to set the tolerance for the time adapters |
SentryMan
changed the title
SentryMan
changed the title
|
Yeah, I'm good with this |
|
oh wait I forgot the number ones |
|
should be good now |
rbygrave
approved these changes
Jun 19, 2023
| return true; | ||
| } | ||
|
|
||
| if (pattern.test(value.toString())) { |
There was a problem hiding this comment.
This looks wrong / inverted boolean ? Kind of expecting a test to fail ? Hmm.
There was a problem hiding this comment.
Ok, there is the negate() there ... not sure how the tests previously passed?
validator/src/main/java/io/avaje/validation/core/adapters/BasicAdapters.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.