-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Boolean Nulls/Refactor Time Adapters/Adapter Tests #55
Conversation
This reverts commit 0c070da.
hmm, it seems we will need a way to set the tolerance for the time adapters |
Yeah, I'm good with this |
oh wait I forgot the number ones |
should be good now |
return true; | ||
} | ||
|
||
if (pattern.test(value.toString())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong / inverted boolean ? Kind of expecting a test to fail ? Hmm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, there is the negate() there ... not sure how the tests previously passed?
As the title says.