Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Jakarta annotation attribute map generation #35

Merged
merged 1 commit into from
May 22, 2023
Merged

Change Jakarta annotation attribute map generation #35

merged 1 commit into from
May 22, 2023

Conversation

rbygrave
Copy link
Contributor

  • Maps the jakarta key to avaje key
  • Suppresses defaults for payload and groups

@rbygrave
Change Jakarta annotation attribute map generation
069a3d7 
- Maps the jakarta key to avaje key
- Suppresses defaults for payload and groups
@rbygrave rbygrave merged commit a35b9a2 into main May 22, 2023
@rbygrave rbygrave self-assigned this May 22, 2023
@rbygrave rbygrave deleted the feature/jakarta-message-attributes branch May 22, 2023 00:16
@SentryMan
Copy link
Collaborator

SentryMan commented May 22, 2023 •
edited
Loading

Don't forget javax validation

@rbygrave
Copy link
Contributor Author

Don't forget javax validation

Ha ha, I already have :) ... opps

@SentryMan
Copy link
Collaborator

SentryMan commented May 22, 2023 •
edited
Loading

Also since we have suppressed payload and groups, we have no way to use those, shall I remove from the avaje constraint annotations?

@SentryMan
Copy link
Collaborator

Ah wait, misread those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rbygrave rbygrave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbygrave @SentryMan