-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now write default annotation values to adapter Attributes #33
Conversation
Oh wow - very cool !!! |
The Annotation Mirror API is pretty arcane I would say, now I just gotta fix these tests |
Ah, this looks like the one default value that we didn't want it seems. Edit: But maybe we want it on custom validators in the future ... |
it's possible some may want to use the same jakarta properties yeah |
Not really or at least this is not the case for the Jakarta validator that we support out of the box. All of those ones will use the So for example, in BasicAdapters these are all going to translate to |
were we not going to give the ability to specify what resource bundle path to use? If we have that there is no need to modify it too much. |
but feel free to modify the PR |
Ok, I'll merge this in. I intentionally left out the |
now attributes should work as expected