Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust @Length & @Size to have a max only message #102

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Adjust @Length & @Size to have a max only message #102

merged 6 commits into from
Aug 1, 2023

Conversation

rbygrave
Copy link
Contributor

@rbygrave rbygrave commented Aug 1, 2023

No description provided.

@rbygrave
With @Length(max=..) we get the msg "Length must be between 0 and ..."
3c03b89 
But it would be nicer to have a msg more like:
"maximum length {max} exceeded"

as the min is not used in the validation
@rbygrave
With @Length(max=..) use "maximum length {max} exceeded"
cbe0a2a 
So use a more specific message when only max is specified as the min is not used in the validation (so to me the message including the min 0 isn't as good).
@rbygrave
With @Length(max=..) Fallback from {avaje.Length.max.message} -> {ava…
2db9871 
…je.Length.message}

So add a specific avaje.Length.max.message on a per language basis
@rbygrave
With @SiZe(max=..) Use {avaje.Size.max.message} en -> "maximum size {…
460df6f 
…max} exceeded"

Fallback for all non-en language to {avaje.Size.message}
@rbygrave
Adjust @SiZe adapter to use the Length messages if _type is String or…
6c93e21 
… CharSequence
@rbygrave
Adjust @SiZe adapter to use the Length messages if _type is String or…
c094e77 
… CharSequence
@sonatype-lift
Copy link

sonatype-lift bot commented Aug 1, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@rbygrave rbygrave merged commit c7b9610 into main Aug 1, 2023
2 checks passed
@rbygrave rbygrave deleted the feature/example-custom-resource branch August 1, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SentryMan SentryMan SentryMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbygrave @SentryMan