Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substrate/upgrade v1.0.0 #41

Merged
merged 18 commits into from
Sep 13, 2023
Merged

Substrate/upgrade v1.0.0 #41

merged 18 commits into from
Sep 13, 2023

Conversation

Leouarz
Copy link
Contributor

@Leouarz Leouarz commented Aug 1, 2023

This branch is not meant to be merged right now.
It need to be used to update our node and check for compatibility with node / LC.

Copy link
Collaborator

@fmiguelgarcia fmiguelgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check the node (from develop branch) and LC (from miguel/nalgebra_dep) compilation?
LC could be the issue because it integrates avail-core, avail-subxt and subxt.

@Leouarz
Copy link
Contributor Author

Leouarz commented Aug 2, 2023

Hey, for now, it's only on Avail-core, we'll update the node in the coming days, then check for compilation and versions.

.gitignore Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch coverage: 21.12% and project coverage change: -1.09% ⚠️

Comparison is base (1c34178) 59.22% compared to head (a7e020c) 58.13%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   59.22%   58.13%   -1.09%     
==========================================
  Files          55       54       -1     
  Lines        7521     7644     +123     
==========================================
- Hits         4454     4444      -10     
- Misses       3067     3200     +133     
Files Changed Coverage Δ
core/src/app_extrinsic.rs 21.21% <0.00%> (ø)
core/src/asdr.rs 72.91% <ø> (ø)
core/src/da_block.rs 0.00% <0.00%> (ø)
core/src/header/extension/v2.rs 7.14% <0.00%> (ø)
core/src/keccak256.rs 25.00% <0.00%> (ø)
core/src/opaque_extrinsic.rs 20.00% <ø> (ø)
core/src/sha2.rs 0.00% <0.00%> (ø)
core/src/traits.rs 6.14% <0.00%> (-1.35%) ⬇️
kate/src/com.rs 97.02% <ø> (ø)
kate/src/lib.rs 90.74% <ø> (-0.09%) ⬇️
... and 10 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@markopoloparadox markopoloparadox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markopoloparadox markopoloparadox merged commit 579a6f2 into main Sep 13, 2023
1 check passed
@markopoloparadox markopoloparadox deleted the substrate/upgrade-v1.0.0 branch September 13, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants