-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substrate/upgrade v1.0.0 #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check the node (from develop
branch) and LC (from miguel/nalgebra_dep
) compilation?
LC could be the issue because it integrates avail-core
, avail-subxt
and subxt
.
Hey, for now, it's only on Avail-core, we'll update the node in the coming days, then check for compilation and versions. |
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 59.22% 58.13% -1.09%
==========================================
Files 55 54 -1
Lines 7521 7644 +123
==========================================
- Hits 4454 4444 -10
- Misses 3067 3200 +133
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This branch is not meant to be merged right now.
It need to be used to update our node and check for compatibility with node / LC.