Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for CI #144

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

orien
Copy link
Contributor

@orien orien commented Feb 2, 2023

Proposed change

To give external development teams and the wider community confidence that this project is compatible with the latest versions of Ruby, I propose using GitHub Actions for public CI and to automatically run the test suite against a matrix of supported Ruby versions.

lib/avatax/api.rb Outdated Show resolved Hide resolved
Gemfile Outdated
gemspec

gem 'activesupport', ENV.fetch('RAILS_VERSION', '>= 6.1.7')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add this to the gemspec?

Copy link
Contributor Author

@orien orien Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already an entry for activesuppprt in the gemspec. This is here to influence which specific version is used in the CI build matrix.

I've moved this out to dedicated gemfiles, one for each version of Rails used in the CI build. This should make the intent clear. It's also consistent with how things are done in other projects (eg. Rails).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants