PHP 8 Support

[AmitT]

Hi,
As far as I see, the SDK has a lot of issues with PHP8:

Deprecated: Required parameter $countryCode follows optional parameter $filter in
/vendor/avalara/avataxclient/src/Methods.php
on line 4214

Deprecated: Required parameter $countryCode follows optional parameter $filter in
/vendor/avalara/avataxclient/src/Methods.php
on line 4240

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 6498

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 6644

Deprecated: Required parameter $model follows optional parameter $include in
vendor/avalara/avataxclient/src/Methods.php
on line 6862

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 8893

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 8948

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9125

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9178

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9234

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9297

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9337

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9574

Deprecated: Required parameter $documentType follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9640

Deprecated: Required parameter $useTaxDateOverride follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9640

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9640

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9693

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9836

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9890

Deprecated: Required parameter $environment follows optional parameter $machineName in
/vendor/avalara/avataxclient/src/Client.php
on line 57

Can you please update the SDK accordingly?

Thank you,

[casingh1990]

Has there been any movement on getting this forward? Would like to know if the linked PR is good to go or what changes are needed.

[Nacoma]

Is there an ETA for when we will see PHP8 support? This is a major blocker.

[guywarner]

Based on the response here #138 it doesn't look very good for us.

[guywarner]

Can confirm a temporary fix until they get with it.

Fork https://github.com/dissolve/AvaTax-REST-V2-PHP-SDK by @dissolve.

In your composer.json add:

    "repositories": [
      {
        "url": "https://github.com/**YOUR USERNAME**/AvaTax-REST-V2-PHP-SDK",
        "type": "vcs"
      }
    ],

Will fix PHP 8 and Guzzle 7 issues

[asegestam]

I don't get why this has not been fixed yet. Its been an issue for months now - really frustrating

[guywarner]

I don't either, reason we're moving to Tax Jar

[asegestam]

I don't either, reason we're moving to Tax Jar

Thanks for the tip @guywarner

[philsturgeon]

Come on folks, you've got a PR already just click merge.

[svc-developer]

This has been completed in 22.3.0 release of SDK. Please confirm.
Thanks.