-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update warp readme #765
Update warp readme #765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good as well. I am missing information on best practices or a reference implementation for the encoding/decoding of complex data structures in the message
|
||
However, when Subnet B receives a message from the C-Chain, it changes the semantics to the following: | ||
|
||
1. Read the SourceChainID of the signed message (C-Chain) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really only special case C-Chain or is it all of primary network?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically we special case the whole primary network, but only the C-Chain will originally support warp.
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: aaronbuchwald <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: aaronbuchwald <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: aaronbuchwald <[email protected]>
Why this should be merged
This PR improves the README in
x/warp
and references the new Warp README in AvalancheGo instead of explaining everything in one place.How this works
Updates the Warp README
How this was tested
n/a
How is this documented
This PR is documentation