Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add blockchain.Stop as defer to test #714

Merged
merged 6 commits into from
Jul 3, 2023
Merged

add blockchain.Stop as defer to test #714

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
da87fba
core/blockchain_test.go: review file for appropriate blockchain.Stop(…
najeal Jul 1, 2023
136d4b5
core/test_blockchain.go: revert / fix comment
najeal Jul 2, 2023
dd6c8dc
core/test_blockchain.go: use sync.Once
najeal Jul 2, 2023
e7940f0
core: delete remaining empty lines
najeal Jul 3, 2023
2e8b73e
Differentiate mandatory/optional Subnet-EVM Network Upgrades (#640)
ceyonur Jul 3, 2023
7cc6cfb
Merge branch 'master' into core-blockchain-test-close
najeal Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/test_blockchain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"fmt"
"math/big"
"strings"
"sync"
"testing"

"github.com/ava-labs/subnet-evm/commontype"
Expand Down Expand Up @@ -1187,6 +1188,8 @@ func TestReprocessAcceptBlockIdenticalStateRoot(t *testing.T, create func(db eth
if err != nil {
t.Fatal(err)
}
var stopOnce sync.Once
defer stopOnce.Do(blockchain.Stop)

signer := types.HomesteadSigner{}
// Generate chain of blocks using [genDB] instead of [chainDB] to avoid writing
Expand Down Expand Up @@ -1238,7 +1241,7 @@ func TestReprocessAcceptBlockIdenticalStateRoot(t *testing.T, create func(db eth
t.Fatalf("Expected current block to be %s:%d, but found %s%d", expectedCurrentBlock.Hash().Hex(), expectedCurrentBlock.NumberU64(), currentBlock.Hash().Hex(), currentBlock.NumberU64())
}

blockchain.Stop()
stopOnce.Do(blockchain.Stop)

blockchain, err = create(chainDB, gspec.Config, common.Hash{})
if err != nil {
Expand Down