Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR introduces recognizing, parsing and verification of
ValidatorUptime
messages. Verification is basically skipped and all uptime messages are signed.How this works
This pull request introduces new functionality for verifying addressed call messages and adds corresponding tests and metrics. The main changes include adding a new verification function, updating the switch statement to handle the new message type, and adding test cases and metrics for uptime validation.
New functionality for verifying addressed call messages:
warp/verifier_backend.go
: Added a new import formessages
and implemented theverifyAddressedCall
function to parse and verify addressed call messages. The switch statement in theVerify
function was updated to handlepayload.AddressedCall
messages. [1] [2] [3]Tests for the new functionality:
warp/verifier_backend_test.go
: Added a new import formessages
and implementedTestUptimeSignatures
to test the verification of uptime messages. [1] [2]Metrics for uptime validation:
warp/verifier_stats.go
: Added a new counter foruptimeValidationFail
and a corresponding increment functionIncUptimeValidationFail
. [1] [2]How this was tested
Added UT
How is this documented
No need