Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always sign validator uptimes #1377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Oct 30, 2024

Why this should be merged

This PR introduces recognizing, parsing and verification of ValidatorUptime messages. Verification is basically skipped and all uptime messages are signed.

How this works

This pull request introduces new functionality for verifying addressed call messages and adds corresponding tests and metrics. The main changes include adding a new verification function, updating the switch statement to handle the new message type, and adding test cases and metrics for uptime validation.

New functionality for verifying addressed call messages:

  • warp/verifier_backend.go: Added a new import for messages and implemented the verifyAddressedCall function to parse and verify addressed call messages. The switch statement in the Verify function was updated to handle payload.AddressedCall messages. [1] [2] [3]

Tests for the new functionality:

Metrics for uptime validation:

  • warp/verifier_stats.go: Added a new counter for uptimeValidationFail and a corresponding increment function IncUptimeValidationFail. [1] [2]

How this was tested

Added UT

How is this documented

No need

@ceyonur ceyonur added the DO NOT MERGE This PR is not meant to be merged in its current state label Oct 30, 2024
@ceyonur ceyonur requested review from darioush and a team as code owners October 30, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE This PR is not meant to be merged in its current state Uptime Tracking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant