Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pchain client wrapper with options #568

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cam-schultz
Copy link
Collaborator

Why this should be merged

Alternative to #567

How this works

How this was tested

How is this documented

Copy link
Contributor

@bernard-avalabs bernard-avalabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. It requires more code than the alternative, but it is also less error prone.

richardpringle
richardpringle previously approved these changes Dec 11, 2024
@@ -23,13 +24,13 @@ type InfoAPI struct {
options []rpc.Option
}

func NewInfoAPI(apiConfig *config.APIConfig) (*InfoAPI, error) {
func NewInfoAPI(apiConfig *config.APIConfig) *InfoAPI {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@richardpringle richardpringle self-requested a review December 11, 2024 22:58
@richardpringle richardpringle dismissed their stale review December 11, 2024 22:59

PR not ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants