Validators at proposed #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
requested review from
richardpringle,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
| @@ -98,77 +91,14 @@ func (v *CanonicalValidatorClient) GetValidatorSet( | |||
| ) (map[ids.NodeID]*validators.GetValidatorOutput, error) { | |||
There was a problem hiding this comment.
Should the comment for this function be updated to remove the sentence about falling back to getCurrentValidators?
cam-schultz
reviewed
Nov 19, 2024
geoff-vball
reviewed
Nov 20, 2024
Co-authored-by: bernard-avalabs <[email protected]> Signed-off-by: Ian Suvak <[email protected]>
use local copy of install_avalanchego_release.sh
geoff-vball
approved these changes
Nov 20, 2024
This PR would fail E2E if it wasn't working at all. I'll add an explicit E2E test that relies on proposed height != current p-chain height in a separate PR once a PR resolving #534 is up since that one will bring over latest tmpnet changes over from teleporter |
Closed
richardpringle
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
LGTM, relying of @geoff-vball's review for the deleted code as I don't have the context there.
bernard-avalabs
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Supersedes #506
How this works
getCurrentValidatorsand replaces height passed intogetValidatorsAtfrom the result ofGetCurrentHeightto"proposed"flag.I'm happy to add the
getCurrentValidatorsfallback as well if it's preferred but assuming thatgetValidatorsAt(height: "proposed"is available on public API this would be the safest way of fetching validator sets.How this was tested
Existing tests should pass. These tests fail against previous version of
avalanchegowith the code modifications here.How is this documented