Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process messages concurrently #288
Process messages concurrently #288
Changes from 23 commits
51d4e6f
608022c
a1bdf87
3b0c438
4142101
01a07e3
8cf64a6
678fa92
e8371e3
252b027
f386d11
b5fca25
34eda3f
efa8f3b
de411b9
9f79ca1
7edff1d
2ee56bb
72f6f0c
08235b7
5ffa9dc
90391a6
69dbc80
acbc62d
23dd427
b57d05d
1a051f3
2db03ec
248c852
b5cd801
0930225
4d0cd01
1cd196e
7b345c6
b3c5b5e
8dce7b4
359032d
f1887c9
65a9162
ef461da
cbddf3a
8653be1
610105b
e939eca
0611a3b
b920a0f
757f988
359dde4
00a1d4e
8ed636b
ad391aa
d1936ec
59210e0
f4f44e6
9e55c91
077cea1
1782f31
ba2f686
024ffd2
65b8ba8
3404bf7
7d2f8ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused what the need is to separate
MessageManager
andMessageHandler
here, and worried it could easily be confused what each is intended to be used for in the future.It seems like a
MessageManager
is just a wrapper for creatingMessageHandler
s. Would it be possible to remove it all together and just useNewMessageHandler
directly with additional params as needed? Otherwise, I think we should consider renamingMessageManager
toMessageHandlerFactory
or something similar.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed
MessageManager
toMessageHandlerFactory
, and put both it andMessageHandler
inmessage_handler.go
.