Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update README #259

Merged
merged 2 commits into from
Apr 18, 2024
Merged

docs: update README #259

merged 2 commits into from
Apr 18, 2024

Conversation

Al3xGROS
Copy link
Contributor

@Al3xGROS Al3xGROS commented Apr 9, 2024 •
edited
Loading

Why this should be merged

The field names of the SupportedDestination struct are not currently specified in the README. It's better to add them.

How this works

This PR adds them for better readability.

How this was tested

N/A

How is this documented

N/A

cam-schultz
cam-schultz reviewed Apr 9, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
cam-schultz
cam-schultz approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@cam-schultz cam-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs improvement!

@cam-schultz
Copy link
Collaborator

Sorry @Al3xGROS , we require all commits to be signed. Can you please rebase this branch with signed commits?

@Al3xGROS Al3xGROS force-pushed the upgrade-details-docs-configuration branch 2 times, most recently from 91ed103 to f909ca9 Compare April 10, 2024 09:23
@Al3xGROS Al3xGROS force-pushed the upgrade-details-docs-configuration branch from f909ca9 to a98333d Compare April 10, 2024 09:33
@Al3xGROS
Copy link
Contributor Author

I had some difficulties but it should be good now @cam-schultz.

@geoff-vball geoff-vball merged commit 3f2303f into ava-labs:main Apr 18, 2024
3 checks passed
@geoff-vball
Copy link
Contributor

Thanks a lot @Al3xGROS !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cam-schultz cam-schultz cam-schultz approved these changes

@geoff-vball geoff-vball geoff-vball approved these changes

@michaelkaplan13 michaelkaplan13 Awaiting requested review from michaelkaplan13

@minghinmatthewlam minghinmatthewlam Awaiting requested review from minghinmatthewlam

@bernard-avalabs bernard-avalabs Awaiting requested review from bernard-avalabs

Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Al3xGROS @cam-schultz @geoff-vball