Fix test tags #631
Merged
Fix test tags #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Btw, the test tags were replaced with specific *test packages as well as a linter to stop test-only code being imported in production: ava-labs/avalanchego#3238
darioush
approved these changes
Aug 12, 2024
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
* update min golang * remove build test tag * remove test build tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Test build tags was removed from AvalancheGo
How this works
Removes build test tags from files and cmds
How this was tested
e2e/local tests should cover this.