Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional gatherer #563

Merged
merged 4 commits into from
May 30, 2024
Merged

Remove optional gatherer #563

merged 4 commits into from
May 30, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

Avalanchego is no longer supporting the metrics.OptionalGatherer.

How this works

Simplifies metrics creation.

How this was tested

  • CI

tsachiherman
tsachiherman previously approved these changes May 27, 2024
Copy link

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; not sure if that would require any changes in downstream grafana/datadog dashboards.

plugin/evm/vm.go Show resolved Hide resolved
plugin/evm/vm.go Outdated Show resolved Hide resolved
@darioush darioush enabled auto-merge (squash) May 30, 2024 20:28
@darioush darioush merged commit a1b1045 into master May 30, 2024
8 checks passed
@darioush darioush deleted the remove-optional-gatherer branch May 30, 2024 21:50
oxbee pushed a commit to taurusgroup/coreth that referenced this pull request Nov 6, 2024
* Remove optional gatherer

* nit

* Do not register chain state metrics when metrics are disabled

---------

Co-authored-by: Darioush Jalali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants