Update pull gossip params to be less bursty #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Patrick O'Grady <[email protected]>
StephenButtolph
requested review from
aaronbuchwald,
darioush and
ceyonur
as code owners
patrick-ogrady
approved these changes
Feb 28, 2024
dhrubabasu
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently - we send
10pull gossip requests every10seconds. This means that the node will only discover transactions from pull gossip every ~10seconds.Additionally, the
10nodes we send requests to may send us duplicate transaction data because we send the same bloom filter to all nodes.This change spreads these requests evenly throughout the
10second window by sending1request every second.This should result in no change in bandwidth (perhaps a slight decrease) and improve the transaction discovery latency.
How this works
to
How this was tested