State sync 1 - Blocks backfilling option #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
force-pushed
the
backfill_blocks
branch
from
56e20ff to
48a940d
Compare
abi87
force-pushed
the
backfill_blocks
branch
from
ee2c85b to
4205d7f
Compare
abi87
commented
Nov 3, 2023
plugin/evm/syncervm_client.go
Outdated
Comment on lines
98
to
99
| BackfillBlocksEnabled(ctx context.Context) (ids.ID, uint64, error) | ||
| BackfillBlocks(ctx context.Context, blocks [][]byte) (ids.ID, uint64, error) |
There was a problem hiding this comment.
not sure where these methods should be implemented. They are part of the StateSync interface so this is the natural place; but their implementation needs the full vm (to parse and store blocks) which is not passed to the state sync client.
For now I end up providing functions to parse and get blocks via the config, not sure if we have a different canonical way to do this in coreth
abi87
commented
Nov 3, 2023
plugin/evm/syncervm_client.go
Outdated
| break | ||
| } | ||
|
|
||
| if err := blk.Accept(ctx); err != nil { |
There was a problem hiding this comment.
This is most likely wrong. Accepting a past block seems to mess up a whole bunch of metadata.
@darioush I'd love a feedback on how the indexing of past block should be handled (brand new methods? Upgrade block.Accept to handle past blocks? something else?).
5 tasks
abi87
force-pushed
the
backfill_blocks
branch
2 times, most recently
from
7d716b6 to
b7d5280
Compare
abi87
force-pushed
the
backfill_blocks
branch
from
b7d5280 to
e0ae369
Compare
abi87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Counterpart of State sync - Blocks backfilling option
How this works
Missing stuff:
How this was tested
Extra UTs + Fuji run (ongoing)