Expose test network cfg #3573
Merged
Expose test network cfg #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
iansuvak,
richardpringle,
geoff-vball and
joshua-kim
yacovm
approved these changes
Dec 2, 2024
michaelkaplan13
approved these changes
Dec 2, 2024
joshua-kim
reviewed
Dec 3, 2024
joshua-kim
approved these changes
Dec 3, 2024
StephenButtolph
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The TestNetwork utility exposes the p2p stack so that non-node applications can communicate with nodes over p2p. This change makes this utility more flexible by allowing the user to modify the default configuration.
How this works
Adds
NewTestNetworkConfigand modifiesNewTestNetworkto accept anetwork.Configparameter.How this was tested
CI
Need to be documented in RELEASES.md?
No