Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[antithesis] Enable reuse of banff e2e test for antithesis testing #3554

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marun
Copy link
Contributor

@marun marun commented Nov 19, 2024

Why this should be merged

Having to duplicate existing test coverage to benefit from execution with antithesis is not ideal. Better to be able to trivially refactor compatible e2e coverage for reuse. This PR refactors the banff e2e test for reuse with antithesis to demonstrate that this is possible.

How this works

  • adds new APITestFunction type that a compatible e2e test can implement to allow for execution with both ginkgo and antithesis
  • adds ExecuteAPITest helper to simplify execution of an APITestFunction with ginkgo
  • Refactors the banff e2e test into an APITestFunction executed by ExecuteAPITest
  • Refactors the avalanchego antithesis test setup to support execution of the banff test
    • Moves test dispatch into a new function so that panics can be recovered via a deferred function
      • This supports use of require by e2e tests without risking an unhandled panic exiting the test process

How this was tested

CI

TODO

Need to be documented in RELEASES.md?

N/A

@marun marun marked this pull request as draft November 19, 2024 15:24
@marun marun changed the title bE2e reuse [antithesis] Enable reuse of banff e2e test for antithesis testing Nov 19, 2024
@marun marun added the testing This primarily focuses on testing label Nov 19, 2024
@marun marun self-assigned this Nov 19, 2024
@marun marun marked this pull request as ready for review November 19, 2024 18:14
@marun marun marked this pull request as draft November 20, 2024 21:59
@marun
Copy link
Contributor Author

marun commented Nov 20, 2024

Switched to draft in light of wanting to rebase on #3557

@marun marun changed the base branch from master to testing-switch-to-zap November 21, 2024 13:52
Base automatically changed from testing-switch-to-zap to master November 21, 2024 22:39
@marun marun marked this pull request as ready for review November 22, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
Status: In Review 👀
Development

Successfully merging this pull request may close these issues.

1 participant