Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crosschain leftovers #3309

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

ceyonur
Copy link
Contributor

@ceyonur ceyonur commented Aug 19, 2024

Why this should be merged

Removes unused fields & functions, left-overs after cross-chain removal.

How this works

Removes sourceChainID and renames destinationChainID to chainID

How this was tested

existing tests should cover this.

@ceyonur ceyonur marked this pull request as ready for review August 19, 2024 13:10
@ceyonur ceyonur requested a review from darioush August 19, 2024 13:11
Copy link
Contributor

@darioush darioush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure whether it makes sense to leave some of the comments that refer to "Destination Chain", this is kind of nit picking so no action needed imo

@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 21, 2024
Merged via the queue into master with commit a5acbaa Aug 21, 2024
21 checks passed
@StephenButtolph StephenButtolph deleted the remove-crosschain-leftovers branch August 21, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants