Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cross-chain requests #3277

Merged
merged 27 commits into from
Aug 13, 2024
Merged

Remove cross-chain requests #3277

merged 27 commits into from
Aug 13, 2024

Conversation

darioush
Copy link
Contributor

@darioush darioush commented Aug 7, 2024

Why this should be merged

No use cases depend on this

How this works

Deletes code.
Note this bumps the RPC chain version and also sets the Minor version in anticipation of the new release (needed for the compatibility test).

How this was tested

CI

@darioush darioush marked this pull request as ready for review August 8, 2024 16:54
Copy link
Contributor

@marun marun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing changes lgtm

version/constants.go Outdated Show resolved Hide resolved
snow/engine/common/engine.go Outdated Show resolved Hide resolved
snow/engine/common/sender.go Outdated Show resolved Hide resolved
@StephenButtolph StephenButtolph added this to the v1.11.11 milestone Aug 13, 2024
@StephenButtolph StephenButtolph added the cleanup Code quality improvement label Aug 13, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 13, 2024
Merged via the queue into master with commit ab83fb4 Aug 13, 2024
21 checks passed
@StephenButtolph StephenButtolph deleted the remove-crosschain branch August 13, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants