-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tmpnet] Add support for checking rpcchainvm version compatibility #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
tmpnet-check-rpcchain-version
branch
from
August 6, 2024 21:20
4559366
to
30c27f9
Compare
marun
force-pushed
the
tmpnet-check-rpcchain-version
branch
from
August 12, 2024 17:54
7840ff3
to
0978d1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - 2 small comments
Previously, if the rpcchainvm version differed between avalanchego and a VM that a node was configured to support, the node would never become healthy and discovering this would require examining log output. This commit adds support for optionally checking the rpcchainvm version of a VM against the version supported by the configured avalanchego binary.
marun
force-pushed
the
tmpnet-check-rpcchain-version
branch
from
August 13, 2024 23:30
f8d5078
to
bd85c1d
Compare
StephenButtolph
approved these changes
Aug 14, 2024
joshua-kim
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously, if the rpcchainvm version differed between avalanchego and a VM that a node was configured to support, the node would never become healthy and discovering this would require examining log output. This PR adds support for optionally checking the rpcchainvm version of a VM against the version supported by the configured avalanchego binary.
How this works
VersionArgs
for each chain to specify arguments that output version info in json format from a vm binaryHow this was tested
Positive coverage: CI, negative coverage: manual:
TODO