Update code owners #3262
Merged
Update code owners #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
approved these changes
Aug 2, 2024
dhrubabasu
reviewed
Aug 2, 2024
Comment on lines
+4
to
+5
| # If a single PR involves multiple code owners, every code owner should approve | ||
| # a PR prior to merging. |
There was a problem hiding this comment.
Do we want to require code owners to review the entire PR or just the portion that they're owning?
There was a problem hiding this comment.
Just their impacted code seems reasonable
marun
approved these changes
Aug 2, 2024
|
Not for right now, but FYI I've generally found it more sustainable to use Github team handles in the CODEOWNERS file (even for 1 person teams) because then no source changes are needed when team members are added or removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
I have long been the final "Yes/No" for PR review in this repository. The prior CODEOWNERS file was intended to have people grow into this role for some components. The CODEOWNERS will now represent who has the final merge "Yes/No" for a subtree.
This is not a final list, if someone feels that they should own a sub-package please reach out to me to be added to this list.
How this works
Updates CODEOWNERS
How this was tested