[e2e] Enhance post-test bootstrap checks #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
commented
Jul 31, 2024
| @@ -185,34 +191,41 @@ func WithSuggestedGasPrice(ethClient ethclient.Client) common.Option { | |||
| return common.WithBaseFee(baseFee) | |||
| } | |||
|
|
|||
| // Verify that a new node can bootstrap into the network. This function is safe to call | |||
There was a problem hiding this comment.
This avoidance of ginkgo.DeferCleanup was in service of a PR that has since been closed, so it is no longer relevant.
- bootstrap all subnets (a request for hypersdk) - enable post-bootstrap interaction with the node by returning it from the check function and ensuring the node is only stopped at the end of the test (a request for hypersdk) - add bootstrap check to xsvm e2e
marun
force-pushed
the
e2e-enhance-bootstrap-check
branch
from
6dee74f
to
f578241
Compare
aaronbuchwald
approved these changes
Jul 31, 2024
StephenButtolph
approved these changes
Aug 2, 2024
marun
added a commit
that referenced
this pull request
Aug 8, 2024
marun
added a commit
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
As per a request for hypersdk, this PR updates the bootstrap checks at the end of relevant tests to bootstrap all subnets and return a successfully bootstrapped node for further evaluation.
How this works
How this was tested
CI