Cleanup fee.staticCalculator #3210

StephenButtolph · 2024-07-21T18:19:30Z

Why this should be merged

Fees can be calculated purely over unsigned transactions. This is critical to ensure that building transactions is easy.
It felt weird that the static fee calculator wasn't implemented in a way that could be used concurrently.
Removed an incorrect comment

Removes mutable state from the calculator implementation.

Fees are calculated over unsigned txs

9cfa4c9

StephenButtolph added the cleanup Code quality improvement label Jul 21, 2024

StephenButtolph added this to the v1.11.10 milestone Jul 21, 2024

StephenButtolph self-assigned this Jul 21, 2024

StephenButtolph requested review from abi87, danlaine and dhrubabasu as code owners July 21, 2024 18:19

dhrubabasu approved these changes Jul 21, 2024

View reviewed changes

nit

c29bd02

StephenButtolph mentioned this pull request Jul 21, 2024

Implement dynamic fee calculator #3211

Merged

1 task

abi87 approved these changes Jul 22, 2024

View reviewed changes

StephenButtolph added this pull request to the merge queue Jul 22, 2024

Merged via the queue into master with commit f4d8a3c Jul 22, 2024
20 checks passed

StephenButtolph deleted the fees-for-unsigned-txs branch July 22, 2024 18:48