-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network upgrade config #3207
Conversation
d6720a2
to
a2ffd04
Compare
This is failing due to https://github.com/ava-labs/coreth/pull/613/files#r1694251921 |
I think that 1) passing the full upgrade struct around as needed instead of individual upgrade times including adding it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we pass this new config to VMs? For instance Subnet-EVM also has a overridable config that depends on avago's values for networks. I'm not sure if this is strictly required to be correctly supported since this is only for custom networks (I assume for testing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can even disable this option if we're running any subnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be added to the snow.Context
in a followup.
…nchego into refactor-upgrade-schedule
Co-authored-by: Stephen Buttolph <[email protected]>
This PR replaces the constants/per-networkID getter functions for network upgrade timestamps with a network upgrade schedule struct and a single function to retrieve the corresponding upgrade schedule.