Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network upgrade config #3207

Merged
merged 17 commits into from
Aug 1, 2024
Merged

Conversation

aaronbuchwald
Copy link
Collaborator

@aaronbuchwald aaronbuchwald commented Jul 20, 2024

This PR replaces the constants/per-networkID getter functions for network upgrade timestamps with a network upgrade schedule struct and a single function to retrieve the corresponding upgrade schedule.

  • Update Coreth dependency
  • Support configuring upgrade schedule via CLI flags

@aaronbuchwald aaronbuchwald self-assigned this Jul 20, 2024
chains/manager.go Outdated Show resolved Hide resolved
@aaronbuchwald
Copy link
Collaborator Author

@aaronbuchwald
Copy link
Collaborator Author

I think that 1) passing the full upgrade struct around as needed instead of individual upgrade times including adding it to *snow.Context for each VM and 2) updating coreth to align the default local network fork activation times with AvalancheGo should be follow up PRs.

@aaronbuchwald aaronbuchwald marked this pull request as ready for review July 28, 2024 16:20
config/config.go Outdated Show resolved Hide resolved
upgrade/upgrade.go Show resolved Hide resolved
chains/manager.go Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we pass this new config to VMs? For instance Subnet-EVM also has a overridable config that depends on avago's values for networks. I'm not sure if this is strictly required to be correctly supported since this is only for custom networks (I assume for testing).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can even disable this option if we're running any subnet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be added to the snow.Context in a followup.

@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit 8f41c9d Aug 1, 2024
20 checks passed
@StephenButtolph StephenButtolph deleted the refactor-upgrade-schedule branch August 1, 2024 21:49
tsachiherman added a commit that referenced this pull request Aug 5, 2024
Co-authored-by: Stephen Buttolph <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants