Make math.Add64 and math.Mul64 generic #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
abi87,
danlaine and
dhrubabasu
as code owners
StephenButtolph
commented
Jul 19, 2024
Comment on lines
+18
to
+22
| // Deprecated: Add64 is deprecated. Use Add[uint64] instead. | ||
| Add64 = Add[uint64] | ||
|
|
||
| // Deprecated: Mul64 is deprecated. Use Mul[uint64] instead. | ||
| Mul64 = Mul[uint64] |
There was a problem hiding this comment.
These are used by coreth. I was too lazy to make a PR to update the dependency with this. We should remove these once coreth has removed their usage.
abi87
approved these changes
Jul 19, 2024
3 tasks
ARR4N
reviewed
Jul 19, 2024
dhrubabasu
approved these changes
Jul 19, 2024
ARR4N
reviewed
Jul 19, 2024
| require := require.New(t) | ||
|
|
||
| sum, err := Add64(0, maxUint64) | ||
| require.Equal(uint(math.MaxUint), MaxUint[uint]()) |
There was a problem hiding this comment.
asserts throughout. And the bike shed should be purple.
There was a problem hiding this comment.
avalanchego uses require exclusively - not going to bring that convo into this PR haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Resolves the asymmetry between
math.Subandmath.Add64/math.Mul64.How this works
^uint(0) == maxUintHow this was tested