-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add getSubnet to p-chain api reference #3204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipemadero
requested review from
abi87,
danlaine,
dhrubabasu and
StephenButtolph
as code owners
July 19, 2024 01:47
abi87
approved these changes
Jul 19, 2024
sukantoraymond
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think id
exists in the return type:
avalanchego/vms/platformvm/service.go
Lines 430 to 440 in f4d8a3c
// GetSubnetResponse is the response from calling GetSubnet | |
type GetSubnetResponse struct { | |
// whether it is permissioned or not | |
IsPermissioned bool `json:"isPermissioned"` | |
// subnet auth information for a permissioned subnet | |
ControlKeys []string `json:"controlKeys"` | |
Threshold avajson.Uint32 `json:"threshold"` | |
Locktime avajson.Uint64 `json:"locktime"` | |
// subnet transformation tx ID for a permissionless subnet | |
SubnetTransformationTxID ids.ID `json:"subnetTransformationTxID"` | |
} |
StephenButtolph
added
the
documentation
Improvements or additions to documentation or examples
label
Jul 23, 2024
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: felipemadero <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: felipemadero <[email protected]>
StephenButtolph
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Doc is missing and the API call is operative
How this works
Fix the doc
How this was tested