Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getSubnet to p-chain api reference #3204

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

felipemadero
Copy link
Contributor

Why this should be merged

Doc is missing and the API call is operative

How this works

Fix the doc

How this was tested

Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think id exists in the return type:

// GetSubnetResponse is the response from calling GetSubnet
type GetSubnetResponse struct {
// whether it is permissioned or not
IsPermissioned bool `json:"isPermissioned"`
// subnet auth information for a permissioned subnet
ControlKeys []string `json:"controlKeys"`
Threshold avajson.Uint32 `json:"threshold"`
Locktime avajson.Uint64 `json:"locktime"`
// subnet transformation tx ID for a permissionless subnet
SubnetTransformationTxID ids.ID `json:"subnetTransformationTxID"`
}

vms/platformvm/service.md Outdated Show resolved Hide resolved
@StephenButtolph StephenButtolph added the documentation Improvements or additions to documentation or examples label Jul 23, 2024
felipemadero and others added 3 commits July 24, 2024 12:17
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: felipemadero <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: felipemadero <[email protected]>
@StephenButtolph StephenButtolph added this pull request to the merge queue Jul 24, 2024
Merged via the queue into master with commit f6701a7 Jul 24, 2024
20 checks passed
@StephenButtolph StephenButtolph deleted the add-get-subnet-to-api-doc branch July 24, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation or examples
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants