Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Ensure monitoring action compatibility for other repos #3193

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented Jul 16, 2024

The path to the notification script needs to be constructed with github.action_path to be compatible with other repos.

The path to the notification script needs to be constructed with the
action_path rather than hard-coded to be compatible with other repos.
@marun marun self-assigned this Jul 16, 2024
@marun marun added the ci This focuses on changes to the CI process label Jul 16, 2024
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I was grepping ".github/action" and found quite few more instances.
would these also be good candidate for that ?

@marun
Copy link
Contributor Author

marun commented Jul 16, 2024

looks good. I was grepping ".github/action" and found quite few more instances. would these also be good candidate for that ?

All the other instances of that string are in workflows. This change to use the action path is only required for path usage within a custom action.

@StephenButtolph StephenButtolph added this pull request to the merge queue Jul 16, 2024
Merged via the queue into master with commit bf26e3c Jul 16, 2024
20 checks passed
@StephenButtolph StephenButtolph deleted the ci-fix-monitoring-action branch July 16, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This focuses on changes to the CI process
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants