Remove Memo field from P-chain wallet
#2732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
approved these changes
Feb 13, 2024
abi87
reviewed
Feb 15, 2024
There was a problem hiding this comment.
I am favour of the cleanup, but I wonder if instead of "silentily" avoiding to include the memo field in any P-chain tx, we should explicitly err if ops.Memo() is non-empty.
It is probably not super relevant for the P-chain, but it may help wallet UX.
I wonder if we care about this in e2e test (cc @marun) or in cli (cc @felipemadero)
|
I'm going to close this - I think there are still plans to re-introduce the memos into this code... and I think it's probably better to error if someone thinks they're providing memos rather than silently not including them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The
Memofield must be empty post-Durango (#2607). This PR removes it from the P-chain wallet.How this works
Don't populate the
MemofieldHow this was tested
CI