ci: Update shellcheck.sh to pass all args to shellcheck
#2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
approved these changes
Jan 24, 2024
marun
force-pushed
the
ci-shellcheck-args
branch
from
68de7a1 to
6ede30a
Compare
marun
commented
Jan 24, 2024
| # Try to install a local version | ||
| SHELLCHECK="${REPO_ROOT}/bin/shellcheck" |
There was a problem hiding this comment.
Probably preferable to ./build to differentiate artifacts we create vs 3rd party. ./bin is also ignored.
StephenButtolph
approved these changes
Jan 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mboben
pushed a commit
to mboben/avalanchego
that referenced
this pull request
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to vary the output format (e.g.
-f gcc) for local execution (the default is more detailed but not as machine-consumable e.g. for editor consumption).