Fix TestExpiredBuildBlock #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alanchego into fix-expired-build-block-test
dhrubabasu
approved these changes
Jan 23, 2024
aaronbuchwald
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Resolves #2500
This test is flaky: https://github.com/ava-labs/avalanchego/actions/runs/7632544803/job/20792975367?pr=2638
This test likely started flaking when we adding the
MaxBuildDelay. There is a race condition where we may end up blocking for the max build delay... Which causes the test to timeout.How this works
Makes sure that
SetPreferencecan not cause<-toEngineto block.How this was tested