Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup database tests #2654

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Cleanup database tests #2654

merged 7 commits into from
Jan 23, 2024

Conversation

dhrubabasu
Copy link
Contributor

Why this should be merged

It's difficult to tell which sub-test fails if we run them sequentially.

How this works

Uses t.Run for each individual test.

How this was tested

CI

@dhrubabasu dhrubabasu added testing This primarily focuses on testing cleanup Code quality improvement labels Jan 23, 2024
@dhrubabasu dhrubabasu added this to the v1.10.19 milestone Jan 23, 2024
@dhrubabasu dhrubabasu self-assigned this Jan 23, 2024
Base automatically changed from cleanup-database-benchmarks to master January 23, 2024 21:35
@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2024
@StephenButtolph StephenButtolph merged commit 0b344bd into master Jan 23, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the cleanup-database-tests branch January 23, 2024 22:16
chand1012 pushed a commit to multisig-labs/avalanchego that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants