Cleanup database benchmarks #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
added
testing
dhrubabasu
requested review from
danlaine,
darioush,
dboehm-avalabs and
StephenButtolph
as code owners
dhrubabasu
commented
Jan 23, 2024
| require.NotEmpty(b, keys) | ||
| count := len(keys) | ||
|
|
||
| b.Run(fmt.Sprintf("%s_%d_pairs_%d_keys_%d_values_db.get", name, count, len(keys[0]), len(values[0])), func(b *testing.B) { |
There was a problem hiding this comment.
This inner b.Run is useless since there aren't any other sub-tests
StephenButtolph
approved these changes
Jan 23, 2024
darioush
approved these changes
Jan 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
chand1012
pushed a commit
to multisig-labs/avalanchego
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The naming structure for database benchmarks was a bit convoluted. This PR simplifies it.
How this works
They are now standardized to look like this:
pebble_1024_pairs_32_keys_32_values_BatchWriteHow this was tested
manually