Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add historical fork times #2649

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

Currently, fork times are specified twice. Once in coreth and once in avalanchego. This PR is meant to unblock coreth to use avalanchego as a source of truth for fork timestamps.

How this works

Adds historical fork times. See coreth for these timestamps.

How this was tested

N/A

@StephenButtolph StephenButtolph self-assigned this Jan 23, 2024
@StephenButtolph StephenButtolph added the cleanup Code quality improvement label Jan 23, 2024
@StephenButtolph StephenButtolph added this to the v1.10.19 milestone Jan 23, 2024
Copy link
Contributor

@ceyonur ceyonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES PLEASE!

@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 23, 2024
Merged via the queue into master with commit 1f29ab5 Jan 23, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the add-historical-fork-times branch January 23, 2024 18:15
chand1012 pushed a commit to multisig-labs/avalanchego that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants