Improve logging of unexpected proposer errors #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
the
monitoring
StephenButtolph
requested review from
abi87,
danlaine and
joshua-kim
as code owners
StephenButtolph
commented
Jan 22, 2024
| @@ -454,7 +455,7 @@ func (p *postForkCommonComponents) shouldBuildSignedBlockPostDurango( | |||
| // In case the inner VM only issued one pendingTxs message, we should | |||
| // attempt to re-handle that once it is our turn to build the block. | |||
| p.vm.notifyInnerBlockReady() | |||
| return false, errProposerWindowNotStarted | |||
| return false, fmt.Errorf("%w: slot %d expects %s", errUnexpectedProposer, currentSlot, expectedProposerID) | |||
There was a problem hiding this comment.
note the change from errProposerWindowNotStarted to errUnexpectedProposer.
patrick-ogrady
approved these changes
Jan 22, 2024
dhrubabasu
approved these changes
Jan 22, 2024
chand1012
pushed a commit
to multisig-labs/avalanchego
that referenced
this pull request
Oct 1, 2024
Co-authored-by: Patrick O'Grady <[email protected]>
chand1012
pushed a commit
to multisig-labs/avalanchego
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently it is hard to understand why
errProposerWindowNotStartedis being reported. This should improve monitoring.This also aligns the usage of
errProposerWindowNotStarted->pre-durangoanderrUnexpectedProposer->post-durango.How this works
fmt.ErrorfHow this was tested