Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace closeFn with t.Cleanup #2638

Merged
merged 20 commits into from
Jan 23, 2024
Merged

Replace closeFn with t.Cleanup #2638

merged 20 commits into from
Jan 23, 2024

Conversation

dhrubabasu
Copy link
Contributor

Why this should be merged

We currently require consumers of structs with closeFn to call closeFn. We can use t.Cleanup() to do this more robustly.

How this works

Deletes closeFn and moves it to a t.Cleanup call

How this was tested

CI

@dhrubabasu dhrubabasu added testing This primarily focuses on testing cleanup Code quality improvement labels Jan 19, 2024
@dhrubabasu dhrubabasu added this to the v1.10.19 milestone Jan 19, 2024
@dhrubabasu dhrubabasu self-assigned this Jan 19, 2024
@StephenButtolph StephenButtolph marked this pull request as draft January 19, 2024 21:30
@dhrubabasu dhrubabasu marked this pull request as ready for review January 23, 2024 19:43
@dhrubabasu dhrubabasu marked this pull request as draft January 23, 2024 20:01
@dhrubabasu dhrubabasu changed the base branch from master to cleanup-warp-signer-tests January 23, 2024 20:05
Base automatically changed from cleanup-warp-signer-tests to master January 23, 2024 20:27
@dhrubabasu dhrubabasu changed the base branch from master to cleanup-database-benchmarks January 23, 2024 20:28
@dhrubabasu dhrubabasu changed the base branch from cleanup-database-benchmarks to cleanup-database-tests January 23, 2024 20:41
@dhrubabasu dhrubabasu marked this pull request as ready for review January 23, 2024 20:44
Base automatically changed from cleanup-database-tests to master January 23, 2024 22:16
@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 23, 2024
Merged via the queue into master with commit bb2357e Jan 23, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the t-cleanup-close-fn branch January 23, 2024 23:35
chand1012 pushed a commit to multisig-labs/avalanchego that referenced this pull request Oct 1, 2024
Merkledb remove panic during cache eviction (ava-labs#2638)
888bada
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@darioush darioush darioush approved these changes

@abi87 abi87 Awaiting requested review from abi87

@danlaine danlaine Awaiting requested review from danlaine

@dboehm-avalabs dboehm-avalabs Awaiting requested review from dboehm-avalabs

@ceyonur ceyonur Awaiting requested review from ceyonur

Assignees

@dhrubabasu dhrubabasu

Labels
cleanup Code quality improvement testing This primarily focuses on testing
Projects
Platform Engineering Group
Archived in project
Milestone
v1.10.19
Development

Successfully merging this pull request may close these issues.
3 participants
@dhrubabasu @darioush @StephenButtolph