Optimize bloom filter #2588
Merged
Optimize bloom filter #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
gyuho,
danlaine and
joshua-kim
as code owners
| // positive probability of a bloom filter with [numEntries] after [count] | ||
| // additions. | ||
| // | ||
| // It is guaranteed to return a value in the range [minHashes, maxHashes]. |
patrick-ogrady
approved these changes
Jan 5, 2024
dhrubabasu
reviewed
Jan 7, 2024
dhrubabasu
reviewed
Jan 8, 2024
dhrubabasu
reviewed
Jan 8, 2024
dhrubabasu
reviewed
Jan 8, 2024
dhrubabasu
reviewed
Jan 8, 2024
dhrubabasu
approved these changes
Jan 8, 2024
chand1012
pushed a commit
to multisig-labs/avalanchego
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR improves the performance of handling bloom filters over the
p2pnetwork.Old
MarshalNew
MarshalOld
ParseNew
ParseOld
ContainsNew
ContainsHow this works
Note: This PR is not backwards compatible. Updated nodes will drop requested from un-updated nodes (and visa versa).
The major improvements from this PR come from:
Marshalentriesfrom[]uint64to[]byteto avoid needing to allocate a potentially large entries array and then individually pack entries into the array inParse.ContainsHow this was tested