tmpnet: Use AvalancheLocalChainConfig for cchain genesis
#2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpnet has been using an arbitrary cchain genesis configuration that wasn't reflective of desired configuration. Using this new value is intended to ensure consistent behavior in testing.
darioush
approved these changes
Jan 5, 2024
| Config: ¶ms.ChainConfig{ | ||
| ChainID: big.NewInt(43112), // Arbitrary chain ID is arbitrary | ||
| }, | ||
| Config: params.AvalancheLocalChainConfig, |
There was a problem hiding this comment.
tbh it's a little awkward that avalanchego takes dependencies on coreth/params and and coreth/core in this file, but this is not made worse by this PR so I'm approving it.
In the long run coreth should probably provide a better method to create the genesis for external users.
There was a problem hiding this comment.
Happier to have a simpler way to do this, but depending on coreth for the configuration rather than using some arbitrary value seemed like a win.
abi87
approved these changes
Jan 5, 2024
aaronbuchwald
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmpnet has been using an arbitrary cchain genesis configuration that wasn't reflective of desired configuration. Using this new value is intended to ensure consistent behavior in testing.