testing: Ensure CheckBootstrapIsPossible is safe for teardown
#2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `CheckBootstrapIsPossible` depended on ginkgo.DeferCleanup which was preventing its use from a Teardown method in coreth integration testing.
marun
force-pushed
the
tmpnet-coreth-compat
branch
from
57d1f9c to
8c081e6
Compare
aaronbuchwald
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Supports coreth testing PR ava-labs/coreth#377
How this works
Previously
CheckBootstrapIsPossibledepended on ginkgo.DeferCleanup which was preventing its use from a Teardown method in coreth integration testing.How this was tested
CI both here and for the coreth testing PR