[MerkleDB] Make intermediate node cache two layered #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboehm-avalabs
requested review from
danlaine,
darioush,
abi87,
gyuho,
marun,
joshua-kim,
StephenButtolph and
ceyonur
as code owners
dboehm-avalabs
commented
Jan 2, 2024
dboehm-avalabs
changed the title
danlaine
reviewed
Jan 3, 2024
patrick-ogrady
changed the title
danlaine
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flushing of the intermediate nodes on db close is taking too long. Split the cache into two parts, one normal cache that can be large and store nodes in memory and one smaller delayed write cache that will prevent writes, but wont be too large to flush on database close.