Remove len tag parsing from the reflect codec
#2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
approved these changes
Dec 29, 2023
JacobEverly
approved these changes
Dec 29, 2023
StephenButtolph
deleted the
remove-codec-custom-field-len-restrictions
branch
tedim52
pushed a commit
to tedim52/avalanchego
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR is the first in an attempt to remove slice length parsing restrictions from the reflect codec.
How this works
This PR shouldn't impact any validity rules. The only place the
lentag was used in either coreth or avalanchego was vertex parsing. However, vertex verification also enforces this restriction. This means that we may be willing to parse vertices we were previously unwilling to parse, but those new vertices would fail verification. Regardless, because the X-chain was linearized, all vertices already exist and no new vertices will be issued.How this was tested