Fix windowing when no validator is available #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
changed the title
abi87
commented
Dec 21, 2023
| @@ -37,7 +37,7 @@ const ( | |||
| var ( | |||
| _ Windower = (*windower)(nil) | |||
|
|
|||
| ErrNoProposersAvailable = errors.New("no proposers available") | |||
There was a problem hiding this comment.
this becomes an internal error that does not require a special error. Instead we should singla the case where no validators are available to be able to handle it appropriately
abi87
commented
Dec 21, 2023
| @@ -401,7 +401,7 @@ func (p *postForkCommonComponents) shouldBuildBlockPostDurango( | |||
| parentTimestamp time.Time, | |||
| parentPChainHeight uint64, | |||
| newTimestamp time.Time, | |||
| ) error { | |||
| ) (bool, error) { | |||
There was a problem hiding this comment.
flipped the logic to align with verifyPre/PostDurangoBlockDelay. Signed blocks will be the new normal so I chose to signal "should build signed block/should have a proposer" with true
StephenButtolph
approved these changes
Dec 22, 2023
dhrubabasu
approved these changes
Dec 22, 2023
JacobEverly
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
In case a subnet ends up not having any validator, current windowing system would halt. It should instead allow any non-validator to propose
How this works
Whenever there are no validators to be sampled from, we allow any node to propose. We issue an unsigned block in such a casa
How this was tested
CI