Move snow.DefaultConsensusContextTest to snowtest.ConsensusContext
#2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
added
testing
dhrubabasu
requested review from
hexfusion,
StephenButtolph,
abi87,
danlaine,
gyuho and
joshua-kim
as code owners
dhrubabasu
changed the title
snowtest pkgsnow.DefaultConsensusContextTest() to snowtest.EmptyConsensusContext()
dhrubabasu
changed the title
snow.DefaultConsensusContextTest() to snowtest.EmptyConsensusContext()snow.DefaultConsensusContextTest to snowtest.EmptyConsensusContext
joshua-kim
reviewed
Dec 19, 2023
snow/snowtest/snowtest.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func EmptyConsensusContext() *snow.ConsensusContext { |
There was a problem hiding this comment.
Since this is its own snowtest package we could just call this snowtest.ConsensusContext since it's now clear that this is a testing implementation
There was a problem hiding this comment.
Good point, re-named.
|
|
||
| var _ snow.Acceptor = noOpAcceptor{} | ||
|
|
||
| type noOpAcceptor struct{} |
There was a problem hiding this comment.
I don't think there's a reason to not export this
There was a problem hiding this comment.
I prefer to keep things unexported unless we plan on using it elsewhere but open to exporting if people feel differently
dhrubabasu
changed the title
snow.DefaultConsensusContextTest to snowtest.EmptyConsensusContextsnow.DefaultConsensusContextTest to snowtest.ConsensusContext
joshua-kim
approved these changes
Dec 19, 2023
StephenButtolph
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Creates a
snowtestpkg to contain all strictly testing-related structs. This segregates it from our production code.This PR is the first step moving
snow.DefaultConsensusContextTest()tosnowtest.EmptyConsensusContext()How this works
Creates the pkg and moves some testing-related things to it.
How this was tested
CI