Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support json marshalling txs returned from the wallet #2494

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Support json marshalling txs returned from the wallet #2494

merged 1 commit into from
Dec 16, 2023

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

This improves the UX of the wallet by supporting json.Marshal of transactions returned by the wallet.

How this works

  • Initializes the chain context with InitCtx to allow json marshalling of OutputOwners.
  • Initializes FxID(s).

How this was tested

  • CI
  • Manually json marshalling txs against a local network

@StephenButtolph StephenButtolph self-assigned this Dec 16, 2023
@StephenButtolph StephenButtolph added the enhancement New feature or request label Dec 16, 2023
abi87
abi87 approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We should turn the manual tests in UTs (it's ok to do it in a different PR).

@StephenButtolph StephenButtolph added this to the v1.10.18 milestone Dec 16, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Dec 16, 2023
Merged via the queue into dev with commit 21fe503 Dec 16, 2023
17 checks passed
@StephenButtolph StephenButtolph deleted the init-wallet-tx-json branch December 16, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abi87 abi87 abi87 approved these changes

@marun marun marun approved these changes

Assignees

@StephenButtolph StephenButtolph

Labels
enhancement New feature or request
Projects
Platform Engineering Group
Archived in project
Milestone
v1.10.18
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @marun @abi87