Fix race in view iteration #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboehm-avalabs
requested review from
danlaine,
darioush,
abi87,
gyuho,
marun,
hexfusion,
StephenButtolph and
joshua-kim
as code owners
darioush
approved these changes
Dec 14, 2023
|
As an alternative, would it make sense to invalidate all the children of the database on |
Yeah, that would be a fair change too |
danlaine
reviewed
Dec 14, 2023
| return database.ErrClosed | ||
| } | ||
|
|
||
| db.closed.Set(true) | ||
| // mark all children as no longer valid because the db has closed | ||
| db.invalidateChildrenExcept(nil) |
There was a problem hiding this comment.
Can we add a unit test for this? Otherwise LGTM
danlaine
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids race when reading view.invalidated or view.db.closed during iteration