Rename Version message to Handshake
#2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
requested review from
gyuho,
hexfusion,
joshua-kim and
StephenButtolph
as code owners
Merged
joshua-kim
approved these changes
Dec 12, 2023
dhrubabasu
approved these changes
Dec 14, 2023
| // peer to connect to other peers in the network. | ||
| // | ||
| // Peers should drop connections to peers with incompatible versions. | ||
| message Version { | ||
| message Handshake { |
There was a problem hiding this comment.
Probably should be a separate PR - but we should probably rename my_version_time in here as well.
StephenButtolph
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
#2476 (comment)
This message contains a lot more than just the version now.
How this works
Rename.
How this was tested
Existing UT.