vms/platformvm: Remove EnableAdding and DisableAdding from Mempool interface
#2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
abi87,
danlaine and
StephenButtolph
as code owners
dhrubabasu
changed the title
vms/platformvm: Remove EnableAdding and DisableAddingvms/platformvm: Remove EnableAdding and DisableAdding from Mempool interface
| @@ -192,9 +192,7 @@ func (b *builder) ShutdownBlockTimer() { | |||
| // This method removes the transactions from the returned | |||
| // blocks from the mempool. | |||
| func (b *builder) BuildBlock(context.Context) (snowman.Block, error) { | |||
| b.Mempool.DisableAdding() | |||
There was a problem hiding this comment.
Do we need to add some locking to the mempool now? I think there are a number of internal fields (like bytesAvailable) modified on the call to Add, for example?
There was a problem hiding this comment.
No, the context lock is held when the Add function is called
StephenButtolph
approved these changes
Dec 11, 2023
patrick-ogrady
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
These methods were added to prevent an infinite recursion bug. This recursion no longer exists -> cleanup 🧹
How this works
Remove methods
How this was tested
CI