Clean up merkleDB interface and duplicate code #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboehm-avalabs
requested review from
danlaine,
darioush,
abi87,
gyuho,
marun,
StephenButtolph,
hexfusion and
joshua-kim
as code owners
dboehm-avalabs
changed the title
darioush
reviewed
Dec 13, 2023
darioush
approved these changes
Dec 13, 2023
danlaine
reviewed
Dec 19, 2023
danlaine
reviewed
Dec 19, 2023
danlaine
reviewed
Dec 19, 2023
danlaine
reviewed
Dec 19, 2023
x/merkledb/trie.go
Outdated
| } | ||
|
|
||
| // Returns a proof that [bytesPath] is in or not in trie [t]. | ||
| func getProof[T Trie](t T, key []byte) (*Proof, error) { |
There was a problem hiding this comment.
These functions are tested indirectly elsewhere, but it would probably be a good idea to test them directly, too
|
Also can you please update the README to change references to |
…nchego into CleanUpInterfaces
…nto CleanUpInterfaces
danlaine
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the database constructs a view to accomplish a few tasks. With some small adjustments, that is no longer required. Also cleaning up the trie interfaces a little bit. We don't really use a readonlytrie anywhere and the full name of the View is merkleDB.View which I think is pretty clear.